Remove string literal

[Nate-weeks]

Edited several calls to assert.strictEqual in test-crypto-sign-verify.js. I removed third argument string literals that hid the value of verified. The default message should include the values.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[ryzokuken]

LGTM

[BridgeAR]

@Nate-weeks would you be so kind and rebase instead of using merge? :-) otherwise it is not possible to run our CI. Even though in this specific case it is probably not necessary to run it.

[tniessen]

@Nate-weeks Please rebase your changes on top of master instead of adding a merge commit if there are conflicts. In order to undo the merge commit and to properly rebase your changes, follow these steps.

# This is only necessary if you did not add the upstream remote before.
git remote add upstream https://github.com/nodejs/node.git

# Checkout your branch.
git checkout remove-string-literal
# Undo the merge commit.
git reset --hard 10d783c07ca5ac15f013b5bad3709e26cbef87f5
# Make sure your copy of our master branch is up-to-date.
git fetch upstream master
# Rebase on top of our changes.
git rebase upstream/master

git rebase will stop as soon as it encounters a conflict, at which point you will need to follow the instructions on the screen. It is usually a cycle of

1. using git status to determine which files the conflict occurred in,
2. manually resolving the conflicts,
3. telling git that you are done with git add path/to/file/with/conflicts, and
4. resuming the rebase with git rebase --continue.

[Nate-weeks]

Oops, yeah sorry that took me awhile to get to and thanks for the instructions, is this better?

[tniessen]

Yes, thank you! CI: https://ci.nodejs.org/job/node-test-pull-request/13691/

[trivikr]

New CI: https://ci.nodejs.org/job/node-test-pull-request/13859/

[tniessen]

Landed in 92de0eb, thank you @Nate-weeks! 🎉