console: don't swallow stack overflow#19423
Closed
dbkaplun wants to merge 2 commits intonodejs:masterfrom
dbkaplun:console-no-swallow-stack-overflow
Closed
console: don't swallow stack overflow#19423dbkaplun wants to merge 2 commits intonodejs:masterfrom dbkaplun:console-no-swallow-stack-overflow
dbkaplun wants to merge 2 commits intonodejs:masterfrom
dbkaplun:console-no-swallow-stack-overflow
Conversation
Fixes test/parallel/test-console-no-swallow-stack-exceeded.js
nodejs-github-bot
added
console
addaleax
approved these changes
Mar 18, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM, although I’m not sure how this affects behaviour?
BridgeAR
approved these changes
Mar 19, 2018
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
cjihrig
approved these changes
Mar 19, 2018
Member
trivikr
pushed a commit
to trivikr/node
that referenced
this pull request
Mar 26, 2018
Fixes test/parallel/test-console-no-swallow-stack-exceeded.js PR-URL: nodejs#19423 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in d49661b |
targos
pushed a commit
that referenced
this pull request
Mar 27, 2018
Fixes test/parallel/test-console-no-swallow-stack-exceeded.js PR-URL: #19423 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesconsole.logunintentionally swallows stack overflows from V8.MAX_STACK_MESSAGEis never set asais not called. The original code was intentionally platform-agnostic, so this logic avoids platform-specific logic as well.