lib: fix a typo in lib/timers: read though -> read through#19666
Closed
adispring wants to merge 1 commit intonodejs:masterfrom
Closed
lib: fix a typo in lib/timers: read though -> read through#19666adispring wants to merge 1 commit intonodejs:masterfrom
adispring wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
timers
vsemozhetbyt
added
the
fast-track
Contributor
vsemozhetbyt
added
the
author ready
trivikr
approved these changes
Mar 29, 2018
Member
|
Landed in 108c176 |
trivikr
pushed a commit
that referenced
this pull request
Mar 29, 2018
PR-URL: #19666 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member
|
Congrats @adispring for your first contribution to Node.js core! 🎉🎉🎉 |
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
PR-URL: #19666 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2018
PR-URL: #19666 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a typo in ./lib/timers.js:
read though->read throughChecklist