[v6.x backport] doc: fix various nits#19761
Closed
vsemozhetbyt wants to merge 5 commits intonodejs:v6.x-stagingfrom
vsemozhetbyt:backport-19743-to-v6.x
Closed
[v6.x backport] doc: fix various nits#19761vsemozhetbyt wants to merge 5 commits intonodejs:v6.x-stagingfrom vsemozhetbyt:backport-19743-to-v6.x
vsemozhetbyt wants to merge 5 commits intonodejs:v6.x-stagingfrom
vsemozhetbyt:backport-19743-to-v6.x
Conversation
Contributor
Author
|
Refs: #19743 (review) |
Contributor
Author
* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md. * Space infix operators. * Unify quotes in inline code spans (use only single quotes). * Unify `* Returns:` (eliminate deviations). * Dedupe spaces. PR-URL: #19743 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Contributor
Author
|
I've copied the landed PR metadata in the first commit and reword titles in the other commits to hint fixup. CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/419/ |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 13, 2018
* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md. * Space infix operators. * Unify quotes in inline code spans (use only single quotes). * Unify `* Returns:` (eliminate deviations). * Dedupe spaces. Backport-PR-URL: #19761 PR-URL: #19743 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Contributor
|
landed in 4d67369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesBackport of #19743 (proactive)
Commit 1: replace 2 hyphens (
--) by spaced m-dash (—) as perSTYLE_GUIDE.md.Commit 2: space infix operators.
Commit 3: unify quotes in inline code spans (use only single quotes).
Commit 4: unify
* Returns:(eliminate deviations).Commit 5: dedupe spaces.