test: fix test when NODE_OPTIONS env var is set to --trace-warnings#20027
test: fix test when NODE_OPTIONS env var is set to --trace-warnings#20027aks- wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
test
|
@nodejs/testing @nodejs/build |
|
An argument could be made to also clear out the other environment variables. Or maybe allow them to be set but print out a warning that test results may be affected. |
|
@richardlau hm, how about we do both, warn them that test results may get affected if env variables are set. use |
Sounds quite complicated, I'd just unset this one by default for now, and do other things as we need to. If there are reasons to have NODE_OPTIONS set when running the test, we could just introduce an alternative variable like If you want to unset all of them I guess that's fine, but leaving it until someone runs into a problem seems reasonable too. |
|
@gibfahn yep, complicated. i guess we can land this pr as is then? and if we run into some problem in future we can come with some other solution |
BridgeAR
added
the
author ready
|
Landed in 5af28c2 🎉 |
PR-URL: nodejs#20027 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #20027 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #20027 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #20027 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
8 participants
it fixes the issue of tests failing if the shell has
export NODE_OPTIONS='--trace-warnings'setChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes