doc: unify more headings#20046
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-unify-more-headings
Closed
doc: unify more headings#20046vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:doc-unify-more-headings
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-unify-more-headings
Conversation
vsemozhetbyt
added
the
fast-track
Contributor
Author
trivikr
approved these changes
Apr 15, 2018
Member
trivikr
left a comment
trivikr
left a comment
There was a problem hiding this comment.
More backticks need to be removed from headings under Implementation Considerations
Contributor
Author
|
@trivikr I've seen them, but abstained from deletion: these are not formal API sections, just extra notes about previously described API. The similar cases are these subsections: https://github.com/nodejs/node/blob/master/doc/api/async_hooks.md#type They describe parameters from the previous formal signature in more details. All these should not be parsed by, say, JSON doctools as formal API parts, just as misc sections. |
BridgeAR
approved these changes
Apr 15, 2018
BridgeAR
added
the
author ready
Contributor
Author
|
Landed in 6e869be |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #20046 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
PR-URL: #20046 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
PR-URL: nodejs#20046 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesnewfor a constructor, remove()from a class name).Also in passing: