doc: fix suspicious heading emphasis in n-api.md#20086
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-napi-em
Closed
doc: fix suspicious heading emphasis in n-api.md#20086vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:doc-napi-em
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:doc-napi-em
Conversation
vsemozhetbyt
added
the
fast-track
nodejs-github-bot
added
doc
Contributor
Author
|
Please, add 👍 here to approve fast-tracking. |
Contributor
Author
This was referenced Apr 16, 2018
jasnell
approved these changes
Apr 16, 2018
Trott
approved these changes
Apr 16, 2018
kfarnung
approved these changes
Apr 16, 2018
vsemozhetbyt
added
the
author ready
Member
|
+1 to fast-tracking |
Contributor
Author
|
Landed in 7dd6d86 |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 17, 2018
PR-URL: #20086 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 17, 2018
PR-URL: #20086 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesI do not know C++ and N-API domain, so I am not sure what these cases are: some accidental artifacts, intentional markdown emphasis for just these two headings or some not escaped C++ syntax. But rather than creating an issue to ask, I've decided to make a PR so that we can close it if these are not typos.
To check the rendering: napi_open_callback_scope, napi_close_callback_scope.
cc @nodejs/n-api