Skip to content

stream: prevent 'end' to be emitted after 'error' #20104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 2 commits into from
Closed

stream: prevent 'end' to be emitted after 'error' #20104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b69058
stream: prevent 'end' to be emitted after 'error'
mcollina Apr 17, 2018
4038163
fixup: nits
mcollina Apr 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: nits
  • Loading branch information
@mcollina
mcollina committed Apr 17, 2018
commit 40381636751eab3fc296888038f8e0de121e87a6
2 changes: 1 addition & 1 deletion lib/internal/streams/destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function destroy(err, cb) {

if (cb) {
cb(err);
} else if (err && !(readableErrored || writableErrored)) {
} else if (err && !readableErrored && !writableErrored) {
process.nextTick(emitErrorNT, this, err);
}
return this;
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-process-external-stdio-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ if (process.argv[2] === 'child') {
assert.strictEqual(signal, null);
}));

child.stderr.pipe(process.stderr);
child.stdout.destroy();
child.send('go');
}
2 changes: 1 addition & 1 deletion test/parallel/test-stream-duplex-error-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ duplex.on('error', common.mustCall(function() {
duplex.on('end', common.mustNotCall());

duplex.end('hello');
duplex.on('data', function() {});
duplex.resume();