Skip to content

test: add test for fsPromises.lchmod #20584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shisama wants to merge 3 commits into from
Closed

test: add test for fsPromises.lchmod #20584

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a574c3
test: add test for fsPromises.lchmod
May 7, 2018
9050df0
test: fix to run fsPromises.lchmod test on only macOS
May 24, 2018
ea2a7c7
test: fix error that occurs with test for fsPromises.lchmod
May 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add test for fsPromises.lchmod 
To increase test coverage for fs/promises,
add test for fsPromises.lchmod.
  • Loading branch information
Masashi Hirano committed May 25, 2018
commit 8a574c3f3d17199ae7afd14401078cc3389833e3
4 changes: 4 additions & 0 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const {
chmod,
copyFile,
link,
lchmod,
lstat,
mkdir,
mkdtemp,
Expand Down Expand Up @@ -128,7 +129,9 @@ function verifyStatObject(stat) {

if (common.canCreateSymLink()) {
const newLink = path.resolve(tmpDir, 'baz3.js');
const newMode = 0o666;
await symlink(newPath, newLink);
await lchmod(newLink, newMode);
Copy link
Member

@richardlau richardlau May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lchmod is Only available on macOS: https://nodejs.org/dist/latest-v10.x/docs/api/fs.html#fs_fs_lchmod_path_mode_callback

Copy link
Contributor Author

@shisama shisama May 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it. Thank you for your review.


stats = await lstat(newLink);
verifyStatObject(stats);
Expand All @@ -137,6 +140,7 @@ function verifyStatObject(stat) {
(await realpath(newLink)).toLowerCase());
assert.strictEqual(newPath.toLowerCase(),
(await readlink(newLink)).toLowerCase());
assert.strictEqual(stats.mode & 0o777, newMode);

await unlink(newLink);
}
Expand Down