Skip to content

src: add public API to create isolate and context #20639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
helloshuangzi wants to merge 4 commits into from
Closed

src: add public API to create isolate and context #20639

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c48b52
src: add public API to create isolate and context
helloshuangzi May 11, 2018
32f988b
src: use unique_ptr to save Free calls
helloshuangzi May 11, 2018
e658fb7
src: use custom deleter for allocator and isolateData
helloshuangzi May 14, 2018
666c25f
src: polish indention
helloshuangzi May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: polish indention
  • Loading branch information
@helloshuangzi
helloshuangzi committed May 14, 2018
commit 666c25f86393b6a1ef5b311db4bf007594f0fb4f
16 changes: 8 additions & 8 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4624,7 +4624,7 @@ inline int Start(uv_loop_t* event_loop,
int argc, const char* const* argv,
int exec_argc, const char* const* exec_argv) {
std::unique_ptr<ArrayBufferAllocator, decltype(&FreeArrayBufferAllocator)>
allocator(CreateArrayBufferAllocator(), &FreeArrayBufferAllocator);
allocator(CreateArrayBufferAllocator(), &FreeArrayBufferAllocator);
Isolate* const isolate = NewIsolate(allocator.get());
if (isolate == nullptr)
return 12; // Signal internal error.
Expand All @@ -4641,17 +4641,17 @@ inline int Start(uv_loop_t* event_loop,
Isolate::Scope isolate_scope(isolate);
HandleScope handle_scope(isolate);
std::unique_ptr<IsolateData, decltype(&FreeIsolateData)> isolate_data(
CreateIsolateData(
isolate,
event_loop,
v8_platform.Platform(),
allocator.get()),
&FreeIsolateData);
CreateIsolateData(
isolate,
event_loop,
v8_platform.Platform(),
allocator.get()),
&FreeIsolateData);
if (track_heap_objects) {
isolate->GetHeapProfiler()->StartTrackingHeapObjects(true);
}
exit_code =
Start(isolate, isolate_data.get(), argc, argv, exec_argc, exec_argv);
Start(isolate, isolate_data.get(), argc, argv, exec_argc, exec_argv);
}

{
Expand Down