src: order C++ error list alphabetically#20707
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: order C++ error list alphabetically#20707addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
Member
Author
tniessen
approved these changes
May 13, 2018
mscdex
reviewed
May 13, 2018
| @@ -31,7 +32,6 @@ namespace node { | |||
| V(ERR_SCRIPT_EXECUTION_INTERRUPTED, Error) \ | |||
| V(ERR_SCRIPT_EXECUTION_TIMEOUT, Error) \ | |||
| V(ERR_STRING_TOO_LONG, Error) \ | |||
Contributor
There was a problem hiding this comment.
Doesn't the \ at the end of this line need to be removed now?
Member
Author
There was a problem hiding this comment.
We actually try to keep those, so that adding/removing lines has lower overhead, i.e. the previous style was actually the less common one.
TimothyGu
approved these changes
May 13, 2018
trivikr
approved these changes
May 13, 2018
BridgeAR
approved these changes
May 14, 2018
BridgeAR
added
the
author ready
joyeecheung
approved these changes
May 14, 2018
danbev
approved these changes
May 14, 2018
Member
Author
jasnell
approved these changes
May 14, 2018
cjihrig
approved these changes
May 14, 2018
Contributor
|
Landed in 34471c7 |
apapirovski
pushed a commit
that referenced
this pull request
May 16, 2018
PR-URL: #20707 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20707 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes