vm,trace_events: add node.vm trace events category#20728
Closed
jasnell wants to merge 3 commits intonodejs:masterfrom
Closed
vm,trace_events: add node.vm trace events category#20728jasnell wants to merge 3 commits intonodejs:masterfrom
jasnell wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
Member
Author
Member
|
could you possibly rename it to |
addaleax
approved these changes
May 14, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Can’t really review the tracing semantics, but code-wise this seems fine to me
Member
Author
|
@devsnek ... done. Just curious why tho :-) |
Member
|
@jasnell because we have vm.module as well with its own parsing and running and such |
ofrobots
approved these changes
May 15, 2018
BridgeAR
added
the
author ready
Member
Author
|
CI is good. One unrelated flaky failure. |
cjihrig
approved these changes
May 15, 2018
Add basic trace events for node_contextify. These generally align very well with V8.ScriptCompile and V8.ScriptExecute trace events and provide good additional context. For instance, using the node.vm trace category at startup allows us to see exactly how long compilation and init of each of our core modules adds to the startup time.
jasnell
force-pushed
the
contextify-trace-events
branch
from
42aec9f to
2a9679a
Compare
jasnell
added a commit
that referenced
this pull request
May 16, 2018
Add basic trace events for node_contextify. These generally align very well with V8.ScriptCompile and V8.ScriptExecute trace events and provide good additional context. For instance, using the node.vm.script trace category at startup allows us to see exactly how long compilation and init of each of our core modules adds to the startup time. PR-URL: #20728 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 8630eea |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Add basic trace events for node_contextify. These generally align very well with V8.ScriptCompile and V8.ScriptExecute trace events and provide good additional context. For instance, using the node.vm.script trace category at startup allows us to see exactly how long compilation and init of each of our core modules adds to the startup time. PR-URL: #20728 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic trace events for node_contextify. These generally
align very well with V8.ScriptCompile and V8.ScriptExecute
trace events and provide good additional context. For instance,
using the node.vm trace category at startup allows us to see
exactly how long compilation and init of each of our core
modules adds to the startup time.
/cc @nodejs/diagnostics @nodejs/trace-events @nodejs/vm
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes