doc: add note about autocrlf required for tests#20752
Closed
bzoz wants to merge 2 commits intonodejs:masterfrom
Closed
doc: add note about autocrlf required for tests#20752bzoz wants to merge 2 commits intonodejs:masterfrom
bzoz wants to merge 2 commits intonodejs:masterfrom
Conversation
Adds a note to test/README.md that setting autocrlf to true when checking out sources is required for the tests to run successfully. Ref: nodejs#18967
cjihrig
approved these changes
May 15, 2018
trivikr
approved these changes
May 15, 2018
Contributor
vsemozhetbyt
added
the
author ready
Trott
reviewed
May 16, 2018
test/README.md
Outdated
| On how to run tests in this directory, see | ||
| [the contributing guide](../doc/guides/contributing/pull-requests.md#step-6-test). | ||
|
|
||
| For the test to successfully run on Windows, Node.js has to be checked out from |
Trott
approved these changes
May 16, 2018
Contributor
Author
joyeecheung
approved these changes
May 16, 2018
Member
|
This should be fixed by #20754 and adding the comment is not necessary anymore with that PR. |
BridgeAR
removed
the
author ready
Member
|
The issue that the comment mentions got fixed with #20754. Closing. |
Contributor
Author
|
CI has autocrlf set to true, so we will never know if a change does not break test for setups with autocrlf set to false. I would add this note to the docs. |
Trott
added
the
author ready
apapirovski
approved these changes
May 22, 2018
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
I'm in favour of documenting this even if it's currently not needed.
Contributor
|
Landed in 3654cd4 |
apapirovski
pushed a commit
that referenced
this pull request
May 22, 2018
Adds a note to test/README.md that setting autocrlf to true when checking out sources is required for the tests to run successfully. PR-URL: #20752 Ref: #18967 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Adds a note to test/README.md that setting autocrlf to true when checking out sources is required for the tests to run successfully. PR-URL: #20752 Ref: #18967 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
Adds a note to test/README.md that setting autocrlf to true when checking out sources is required for the tests to run successfully. PR-URL: #20752 Ref: #18967 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a note to
test/README.mdthat settingautocrlfto true when checking out sources is required for the tests to run successfully.See #18967, which will fail if the
autocrlfis set to false.Checklist