Closed
Conversation
The references in the COLLABORATOR_GUIDE appear to be in no particular order. Sort in ASCII order.
Member
Author
jasnell
approved these changes
May 16, 2018
| [TSC]: https://github.com/nodejs/TSC | ||
| [`--pending-deprecation`]: doc/api/cli.md#--pending-deprecation | ||
| [git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md | ||
| [`node-core-utils`]: https://github.com/nodejs/node-core-utils |
Contributor
There was a problem hiding this comment.
Backticks go before uppercase letters in ASCII?
Member
Author
There was a problem hiding this comment.
Backticks go before uppercase letters in ASCII?
Backticks are after uppercase and before lowercase.
uppercase letters: 65 through 90
backtick: 96
lowercase letters: 97 through 122
| [contributing]: ./doc/guides/contributing/pull-requests.md#commit-message-guidelines | ||
| [flaky tests]: https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A%22CI+%2F+flaky+test%22y | ||
| [git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata | ||
| [git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md |
Contributor
There was a problem hiding this comment.
git-node before git-node-metadata?
Member
Author
There was a problem hiding this comment.
I did a naïve sort so it's really [git-node] before [git-node-metadata]. I think sorting on the string excluding the [ and ] makes more sense, though, so yeah, I'll swap those two...
vsemozhetbyt
approved these changes
May 17, 2018
Contributor
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
fast-track
trivikr
approved these changes
May 17, 2018
targos
approved these changes
May 17, 2018
cjihrig
approved these changes
May 17, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 17, 2018
The references in the COLLABORATOR_GUIDE appear to be in no particular order. Sort in ASCII order. PR-URL: nodejs#20790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in c7831bb |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
The references in the COLLABORATOR_GUIDE appear to be in no particular order. Sort in ASCII order. PR-URL: #20790 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The references in the COLLABORATOR_GUIDE appear to be in no particular
order. Sort in ASCII order.
Checklist