Skip to content

test: show actual assertion error message with value #20956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thatshailesh wants to merge 3 commits into from
Closed

test: show actual assertion error message with value #20956

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a47e4a3
test: show actual assertion error message with value
thatshailesh May 25, 2018
2ad3a00
Comment removed
thatshailesh May 25, 2018
5c6cf1f
using custom message
thatshailesh May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: show actual assertion error message with value 
on process exit if some assertion error occurs value of `process._exiting`
was hidden, this fix will show the actual error message with value
  • Loading branch information
@thatshailesh
thatshailesh committed May 28, 2018
commit a47e4a3f0164da61f261471bee8222a448a50aaa
9 changes: 4 additions & 5 deletions test/parallel/test-next-tick-when-exiting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
'use strict';

require('../common');
const common = require('../common');
const assert = require('assert');

process.on('exit', () => {
assert.strictEqual(process._exiting, true, 'process._exiting was not set!');
// process._exiting was not set!
Copy link
Member

@lpinca lpinca May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think the comment is not needed.

Copy link
Contributor Author

@thatshailesh thatshailesh May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, Actually this is my first PR, and not sure why windows test failed

I am a mac user, is there anything I can do to fix it?

Copy link
Member

@lpinca lpinca May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is unrelated, don't worry about that.

assert.strictEqual(process._exiting, true);

process.nextTick(() => {
assert.fail('process is exiting, should not be called.');
});
process.nextTick(common.mustNotCall());
Copy link
Member

@Trott Trott May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?:

process.nextTick(common.mustNotCall('process is exiting, should not be called'));

Copy link
Contributor Author

@thatshailesh thatshailesh May 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

});

process.exit();