trace_events: move trace_events to internalBinding#22159
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
trace_events: move trace_events to internalBinding#22159jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
Member
Author
|
There is some minor overlap with #22029 |
Member
Author
33 tasks
targos
approved these changes
Aug 6, 2018
maclover7
added
the
semver-major
Contributor
|
CITGM ( |
trivikr
approved these changes
Aug 7, 2018
joyeecheung
approved these changes
Aug 7, 2018
maclover7
approved these changes
Aug 7, 2018
Contributor
maclover7
left a comment
maclover7
left a comment
There was a problem hiding this comment.
CITGM results look okay, LGTM if CI passes
jasnell
force-pushed
the
trace-events-internal-binding
branch
from
4a91a3f to
13d5db5
Compare
Member
Author
|
Updated CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/16300/ |
jasnell
added a commit
that referenced
this pull request
Aug 9, 2018
PR-URL: #22159 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Member
Author
|
Landed in c1e2d6b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
process.binding('trace_events')tointernalBinding('trace_events')Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes