Merged
Conversation
nodejs-github-bot
added
the
c++
3 tasks
Contributor
jdalton
reviewed
Aug 11, 2018
src/node.cc
Outdated
Member
There was a problem hiding this comment.
What were the NODE_HAVE_I18N_SUPPORT checks about?
Contributor
|
FWIW, there already were some doubts about the connection between Intl support and some CLI flags in #19878 |
TimothyGu
approved these changes
Aug 12, 2018
Member
There was a problem hiding this comment.
nit: I'd rather be consistent with the existing entries in terms of style.
Contributor
There was a problem hiding this comment.
Test still fails. Is NODE_PRESERVE_SYMLINKS still needed in this check?
Member
Author
Contributor
|
Rebuild flaky and failed jobs: |
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
PR-URL: #22271 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22271 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes