build: exclude npm test directories on Windows#23001
build: exclude npm test directories on Windows#23001richardlau merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
build
|
For reference, this is the relevant bit of Lines 84 to 89 in 058c5b8 |
vcbuild.bat
Outdated
There was a problem hiding this comment.
robocopy documentation has the syntax as robocopy <Source> <Destination> [<File>[ ...]] [<Options>] so I've moved the existing option (/e) to the end of the command line in addition to the new option to exclude test directories.
|
cc @nodejs/build-files @nodejs/platform-windows @nodejs/npm |
|
Also note this is going to be tricky to test as the regular CI doesn't build the installer/7z/zip packages. |
|
There is a https://github.com/nodejs/build/blob/master/jenkins/xml/smoketest-release.xml in the build repo, I wonder what it's for...can we use it? Is it somewhere on Jenkins? |
Not (as far as I can see) on https://ci.nodejs.org/view/All/. Maybe it's on ci-release (which I don't have access to)? |
|
Any chance we can make Landed under the title I triggered a test build https://ci-release.nodejs.org/job/iojs+release/3779/ |
It's certainly possible but it's not a one line change. We'd have to take into account the differences between the directory layouts on Windows vs the Unix-like platforms and things like symlinks not being used on Windows. Also even though I know it's not a supported platform I wonder if changing |
Thanks. Could you, or someone else who has access the release ci report back on the results when the build completes? |
|
No |
|
I realised on the way home that this change only affects the 7z/zip packages. Will need to look at the WiX files to work out if we can do the equivalent for the msi installer. |
|
I think this is the bit that generates the npm files for WiX: node/tools/msvs/msi/nodemsi.wixproj Line 76 in 9d71e6a |
I think it should work off the directory generated by the P.S. I just checked, the msi does indeed contain |
|
Yes, I think working off the directory created for |
@richardlau Is this WIP? I’m adding the label but please remove it if I’m mistaken about that. |
Yes, thanks. I don't think we should merge this unless the contents of the msi installer match the 7z/zip packages. |
|
@richardlau thanks for working on this! The relevant upstream issue is wixtoolset/issues#4023, so there is no easy way to exclude the tests with Heat. It should be easy to get the |
|
Updated:
I gave this a quick build/install locally and no npm and/or npm dependency |
richardlau
added
install
joaocgreis
added
the
semver-major
|
This should be semver-major. While I can't think of a good reason anything would break, we are removing files from the published packages and installer. This already has the necessary TSC reviews, unless @joyeecheung or @jasnell withdraw their approvals. |
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17477/ ✔️ |
@jasnell I added a second commit for the msi installer after your approval; does this still look good to you? The most recent resume CI is green, so I'd like to land this early next week to make the cc @nodejs/tsc (as per https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#involving-the-tsc since this is defensively |
richardlau
force-pushed
the
npm-win-no-tests
branch
from
89c37c2 to
d8c67a4
Compare
npm test directories are excluded on other platforms by `tools/install.py`. Do the same on Windows. Fixes: nodejs#22901 PR-URL: nodejs#23001 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
richardlau
force-pushed
the
npm-win-no-tests
branch
from
d8c67a4 to
b3b3f53
Compare
|
Landed in b3b3f53. |
8 participants
npm test directories are excluded on other platforms by
tools/install.py. Do the same on Windows.Fixes: #22901
Checklist