Skip to content

deps,v8: link with atomic for platforms lacking CAS #23286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 9 commits into from
Closed

deps,v8: link with atomic for platforms lacking CAS #23286

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c679d80
deps: update V8 to 7.1.0
targos Oct 5, 2018
7adef39
build: reset embedder string to "-node.0"
targos Oct 5, 2018
37bb409
src: update NODE_MODULE_VERSION to 68
targos Oct 5, 2018
193ee73
deps: update v8.gyp
targos Aug 29, 2018
34671d2
deps: update v8.gyp
targos Oct 5, 2018
d172625
deps: V8 sync gypfiles with 7.1
refack Oct 4, 2018
f84d485
deps,v8: link with `atomic` for platforms lacking CAS
refack Oct 5, 2018
6e24dcc
temprary fix for CI
refack Oct 2, 2018
24ffb72
fixup! 1
refack Oct 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! 1
  • Loading branch information
@refack
refack committed Oct 5, 2018
commit 24ffb7256789ef0ed3c5e30087bdf0506a865e91
4 changes: 2 additions & 2 deletions deps/v8/gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,8 @@
'../src/builtins/builtins-intl-gen.cc',
],
}],
# Platforms that don't have CAS support need to link atomic library
# to implement atomic memory access
# Platforms that don't have Compare-And-Swap support need to link atomic
# library to implement atomic memory access
[ 'v8_current_cpu == "mips" or v8_current_cpu == "mipsel" or '
'v8_current_cpu == "mips64" or v8_current_cpu == "mips64el" or '
'v8_current_cpu == "ppc" or v8_current_cpu == "ppc64" or '
Expand Down