test: add test for a vm indexed property#23318
Closed
conectado wants to merge 4 commits intonodejs:masterfrom
Closed
test: add test for a vm indexed property#23318conectado wants to merge 4 commits intonodejs:masterfrom
conectado wants to merge 4 commits intonodejs:masterfrom
Conversation
Adds a single test for a vm with an indexed property.
devsnek
approved these changes
Oct 7, 2018
Member
devsnek
left a comment
devsnek
left a comment
There was a problem hiding this comment.
Specifically this test adds coverage for IndexedPropertyGetterCallback and IndexedPropertyDeleterCallback
Member
|
@nodejs/vm |
refack
reviewed
Oct 7, 2018
jdalton
reviewed
Oct 7, 2018
|
|
||
| const x = vm.createContext({ get a() { return 5; } }); | ||
|
|
||
| assert.strictEqual(x.a, 5); |
Member
There was a problem hiding this comment.
Does IndexedPropertyGetterCallback apply for properties returning index values or indexed properties?
Reflect.defineProperty(x, '1', { get() { return 2 } })
Contributor
Author
There was a problem hiding this comment.
I just tested that scenario and in fact, x[1] === 2. If that's the question. I'm not sure I quite understand it.
jdalton
suggested changes
Oct 7, 2018
Member
jdalton
left a comment
jdalton
left a comment
There was a problem hiding this comment.
This test doesn't look like its testing index-like property names and is instead checking properties with index-like values. I'm not entirely sure what this test is trying to cover.
Contributor
Author
|
@jdalton How about now? We are accessing indexed property |
jdalton
approved these changes
Oct 8, 2018
Member
|
Could you add a comment above the test explaining which component it's testing, e.g. |
Contributor
Author
|
@jdalton done |
jasnell
approved these changes
Oct 8, 2018
refack
approved these changes
Oct 8, 2018
Contributor
refack
added
the
author ready
Contributor
|
Landed in b409eaa. |
danbev
pushed a commit
that referenced
this pull request
Oct 11, 2018
Adds a single test for a vm with an indexed property. PR-URL: #23318 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 12, 2018
Adds a single test for a vm with an indexed property. PR-URL: #23318 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Adds a single test for a vm with an indexed property. PR-URL: #23318 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
Adds a single test for a vm with an indexed property. PR-URL: #23318 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Adds a single test for a vm with an indexed property. PR-URL: #23318 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Adds a single test for a vm with an indexed property. PR-URL: #23318 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a test for a vm with a single indexed property
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes