test: replace assert.throws w/ common.expectsError#23454
Closed
aeisenberg wants to merge 2 commits intonodejs:masterfrom
Closed
test: replace assert.throws w/ common.expectsError#23454aeisenberg wants to merge 2 commits intonodejs:masterfrom
aeisenberg wants to merge 2 commits intonodejs:masterfrom
Conversation
Converts RangeError assertions to use common.expectsError and includes an assertion for the error code.
gireeshpunathil
added
the
code-and-learn
gireeshpunathil
approved these changes
Oct 12, 2018
cjihrig
approved these changes
Oct 12, 2018
addaleax
approved these changes
Oct 12, 2018
Contributor
Author
|
Thanks for the quick turn around.
…On Fri, Oct 12, 2018 at 10:09 AM Anna Henningsen ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23454 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWMJ4Ws9GrapEJ8M7YtQ7hBEu7A1BCyks5ukMy_gaJpZM4XZz1d>
.
|
jasnell
approved these changes
Oct 12, 2018
trivikr
reviewed
Oct 12, 2018
Trims some lines of code and makes the tests easier to read.
trivikr
approved these changes
Oct 13, 2018
Member
thefourtheye
approved these changes
Oct 13, 2018
Member
|
Collaborators, please 👍 here to approve fast-tracking. |
Trott
added
fast-track
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 13, 2018
Converts RangeError assertions to use common.expectsError and includes an assertion for the error code. PR-URL: nodejs#23454 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
|
Landed in 0005846. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Converts RangeError assertions to use common.expectsError and includes an assertion for the error code. PR-URL: #23454 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts RangeError assertions to use common.expectsError and includes
an assertion for the error code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes