Skip to content

FAST HTTP YEAH #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 4 commits into from
Closed

FAST HTTP YEAH #2355

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59b91f1
http_parser: consume StreamBase instance
indutny Aug 12, 2015
bc82108
improvement
indutny Aug 26, 2015
d94f7f4
env: introduce `KickNextTick`
indutny Aug 26, 2015
5cb0a0e
http_parser: follow-up fixes
indutny Aug 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improvement
  • Loading branch information
@indutny
indutny committed Aug 26, 2015
commit bc821080b2034662bdb1c4fdf83abcafb19331e5
11 changes: 9 additions & 2 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ Server.prototype.setTimeout = function(msecs, callback) {
exports.Server = Server;


function noop() {
}


function connectionListener(socket) {
var self = this;
var outgoing = [];
Expand Down Expand Up @@ -328,7 +332,10 @@ function connectionListener(socket) {
// Override on to unconsume on `data`, `readable` listeners
socket.on = socketOnWrap;

parser.consume(socket._handle._externalStream);
var external = socket._handle._externalStream;
if (external)
parser.consume(external);
external = null;
parser[kOnExecute] = onParserExecute;

// TODO(isaacs): Move all these functions out of here
Expand All @@ -349,7 +356,7 @@ function connectionListener(socket) {
onParserExecuteCommon(ret, undefined);

// Kick-off next ticks
setImmediate(function() {});
setImmediate(noop);
}

function onParserExecuteCommon(ret, d) {
Expand Down