Skip to content

fs: make writeFile consistent with readFile wrt fd #23709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thefourtheye wants to merge 3 commits into from
Closed

fs: make writeFile consistent with readFile wrt fd #23709

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acae706
fs: make writeFile consistent with readFile wrt fd
thefourtheye Oct 17, 2018
adca945
test: test if {read,write}File honour file position
thefourtheye Oct 17, 2018
e2bca19
address @BridgeAR's comments
thefourtheye Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
address @BridgeAR's comments
  • Loading branch information
@thefourtheye
thefourtheye committed Oct 19, 2018
commit e2bca192337a54a55ffadccf73e6d18d3ef15856
4 changes: 2 additions & 2 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,7 +1191,7 @@ function writeFile(path, data, options, callback) {
function writeFd(fd, isUserFd) {
const buffer = isArrayBufferView(data) ?
data : Buffer.from('' + data, options.encoding || 'utf8');
const position = /a/.test(flag) || isUserFd ? null : 0;
const position = (/a/.test(flag) || isUserFd) ? null : 0;

writeAll(fd, isUserFd, buffer, 0, buffer.byteLength, position, callback);
}
Expand All @@ -1209,7 +1209,7 @@ function writeFileSync(path, data, options) {
}
let offset = 0;
let length = data.byteLength;
let position = /a/.test(flag) || isUserFd ? null : 0;
let position = (/a/.test(flag) || isUserFd) ? null : 0;
try {
while (length > 0) {
const written = fs.writeSync(fd, data, offset, length, position);
Expand Down