assert: respect assert.doesNotThrow message.#2406
Closed
diversario wants to merge 1 commit intonodejs:masterfrom
diversario:fix/2385-inconsistency-in-assert-doesnotthrow
Closed
assert: respect assert.doesNotThrow message.#2406diversario wants to merge 1 commit intonodejs:masterfrom diversario:fix/2385-inconsistency-in-assert-doesnotthrow
diversario wants to merge 1 commit intonodejs:masterfrom
diversario:fix/2385-inconsistency-in-assert-doesnotthrow
Conversation
Addresses #2385. Special handling to detect when user has supplied a custom message. Added a test for user message. When testing if `actual` value is an error use `util.isError` instead of `instanceof`.
Author
|
Sorry, I'm gonna close this and open another one because I messed up commits :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2385.
Special handling to detect when user has supplied a custom message.
Added a test for user message.
When testing if
actualvalue is an error useutil.isErrorinstead ofinstanceof.Replaces nodejs/node-v0.x-archive#6470.