src,lib: prefer internal/options over process._foo#25063
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src,lib: prefer internal/options over process._foo#25063addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
mscdex
reviewed
Dec 15, 2018
lib/internal/bootstrap/node.js
Outdated
Contributor
There was a problem hiding this comment.
We could keep the same extraction method as before with:
({ getOptionValue } = NativeModule.require('internal/options'));
Member
Author
There was a problem hiding this comment.
@mscdex I thought about it but thought this was maybe easier to read without the parenthesis? If you’d prefer this, I’d be totally okay with that too?
Contributor
There was a problem hiding this comment.
I don't mind either way, was just throwing that out there.
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up).
addaleax
force-pushed
the
less-process-dot-something
branch
from
174cee9 to
8f105f8
Compare
joyeecheung
approved these changes
Dec 16, 2018
Member
There was a problem hiding this comment.
LGTM. Thanks for picking this up! I tried to take a stab at this a while back but it was more tricky than I thought to eliminate some of these from JS land (tests were failing/hanging for legit reasons which I was not able to figure out), but it's good to get rid of them incrementally 👍 And looking forward to the followup!
cjihrig
approved these changes
Dec 16, 2018
jasnell
approved these changes
Dec 17, 2018
Contributor
Contributor
|
Re-run of failing node-test-commit-aix ✔️ |
Contributor
|
Landed in 8b57208. |
danbev
pushed a commit
that referenced
this pull request
Dec 21, 2018
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: #25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
This doesn't land cleanly on v11.x, should it be backported? |
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: #25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Applies cleanly now. |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: nodejs#25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This addresses a couple `TODO` comments and allows us to remove a number of underscored properties from `process` (in a semver-major follow-up). PR-URL: nodejs#25063 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a couple
TODOcomments and allows usto remove a number of underscored properties from
process(in a semver-major follow-up).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes