src: initialize Environment members in class definition#25369
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: initialize Environment members in class definition#25369addaleax wants to merge 1 commit intonodejs:masterfrom
Environment members in class definition#25369addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Initialize primitive members of `Environment` in the class definition for clarity.
nodejs-github-bot
added
the
c++
lpinca
approved these changes
Jan 6, 2019
jasnell
approved these changes
Jan 7, 2019
JungMinu
approved these changes
Jan 7, 2019
Contributor
mmarchini
approved these changes
Jan 7, 2019
cjihrig
approved these changes
Jan 7, 2019
Member
Author
addaleax
added
the
author ready
richardlau
approved these changes
Jan 8, 2019
Member
Author
|
Landed in 8d893f2 |
addaleax
added a commit
that referenced
this pull request
Jan 8, 2019
Initialize primitive members of `Environment` in the class definition for clarity. PR-URL: #25369 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
added a commit
that referenced
this pull request
Jan 9, 2019
Initialize primitive members of `Environment` in the class definition for clarity. PR-URL: #25369 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Initialize primitive members of `Environment` in the class definition for clarity. PR-URL: nodejs#25369 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize primitive members of
Environmentin the class definition for clarity.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes