test,worker: verify that .terminate() breaks microtask queue#25480
Hidden character warning
test,worker: verify that .terminate() breaks microtask queue#25480addaleax wants to merge 1 commit intonodejs:masterfrom
.terminate() breaks microtask queue#25480Conversation
|
@addaleax sadly an error occured when I tried to trigger a build :( |
|
@hashseed Does this mean that https://bugs.chromium.org/p/v8/issues/detail?id=8465 has been resolved? |
|
(I’m noticing that it probably hasn’t been resolved, because adding |
|
I haven't had time to take a look there yet. I think it has already been fixed, but there may be some cases where things are still not working correctly. |
|
Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/20241/ |
|
The Windows results look like infra failures, so I’m a bit confused… Full New CI: https://ci.nodejs.org/job/node-test-pull-request/20245/ (✔️ ) |
FYI, binaries are currently deleted after 7 days (nodejs/build#1515 (comment)) so you have that long to resume a build, after which you will need to kick off a brand new CI. |
|
Landed in 2c9e12e. |
PR-URL: #25480 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25480 Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes