doc: add a note to buf.fill() description#25547
Closed
vsemozhetbyt wants to merge 2 commits intonodejs:masterfrom
vsemozhetbyt:doc-buf-fill-255
Closed
doc: add a note to buf.fill() description#25547vsemozhetbyt wants to merge 2 commits intonodejs:masterfrom vsemozhetbyt:doc-buf-fill-255
buf.fill() description#25547vsemozhetbyt wants to merge 2 commits intonodejs:masterfrom
vsemozhetbyt:doc-buf-fill-255
Conversation
nodejs-github-bot
added
buffer
Contributor
Author
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
mscdex
reviewed
Jan 17, 2019
addaleax
approved these changes
Jan 17, 2019
Co-Authored-By: vsemozhetbyt <vsemozhetbyt@gmail.com>
Contributor
Author
antsmartian
approved these changes
Jan 18, 2019
antsmartian
added
the
author ready
jasnell
approved these changes
Jan 18, 2019
Contributor
Author
|
Landed in c1ac578 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jan 19, 2019
PR-URL: #25547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
Author
|
Should be backported with the correction: #25585 |
3 tasks
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
PR-URL: #25547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #25547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #25547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #25547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes