test: run html/webappapis/timers WPT#25618
Closed
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Closed
test: run html/webappapis/timers WPT#25618joyeecheung wants to merge 2 commits intonodejs:masterfrom
joyeecheung wants to merge 2 commits intonodejs:masterfrom
Conversation
Member
Author
Using ``` git node wpt html/webappapis/timers ```
joyeecheung
force-pushed
the
timers-wpt
branch
from
2350ac3 to
92d6c82
Compare
Member
Author
Member
Author
|
Ping @nodejs/testing |
jasnell
approved these changes
Jan 29, 2019
joyeecheung
added
the
author ready
Member
Author
Member
Author
|
CI was green, though node-test-commit got interrupted so the final status was red |
Member
Author
|
Landed in 4b6e4c1...d9066be |
joyeecheung
added a commit
that referenced
this pull request
Jan 31, 2019
Using ``` git node wpt html/webappapis/timers ``` PR-URL: #25618 Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Jan 31, 2019
PR-URL: #25618 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
Using ``` git node wpt html/webappapis/timers ``` PR-URL: #25618 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 1, 2019
PR-URL: #25618 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: pull html/webappapis/timers WPT
Using
test: run html/webappapis/timers WPT
Note that currently only
missing-timeout-setinterval.any.jsgets run - other tests are not yet ported to .js in the upstream.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes