Skip to content

vm: do not overwrite error when creating context #26112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

vm: do not overwrite error when creating context #26112

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3ac28c
vm: do not overwrite error when creating context
addaleax Feb 14, 2019
5d74e49
fixup! vm: do not overwrite error when creating context
addaleax Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! vm: do not overwrite error when creating context
  • Loading branch information
@addaleax
addaleax committed Feb 15, 2019
commit 5d74e49b8bc712828442036fc72d31fd34b7cac7
4 changes: 3 additions & 1 deletion test/parallel/test-worker-vm-context-terminate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ const { Worker } = require('worker_threads');
if (!process.env.HAS_STARTED_WORKER) {
process.env.HAS_STARTED_WORKER = 1;
const w = new Worker(__filename);
setTimeout(() => w.terminate(), 50);
w.on('online', common.mustCall(() => {
setTimeout(() => w.terminate(), 50);
}));
w.on('error', common.mustNotCall());
w.on('exit', common.mustCall((code) => assert.strictEqual(code, 1)));
} else {
Expand Down