Skip to content

doc: add examples for tty.getColorDepth() env #26248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 5 commits into from
Closed

doc: add examples for tty.getColorDepth() env #26248

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
462fcfb
doc: add examples for tty.getColorDepth() env
BridgeAR Feb 21, 2019
6f0d65c
fixup: add comma
Trott Feb 21, 2019
049c69d
fixup: add comma
Trott Feb 21, 2019
5c8189e
fixup: add suggestion
BridgeAR Feb 21, 2019
6e82571
fixup: fix comment about disabling support
BridgeAR Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: add comma 
Co-Authored-By: BridgeAR <ruben@bridgewater.de>
  • Loading branch information
@Trott @BridgeAR
Trott and BridgeAR authored Feb 21, 2019
commit 6f0d65c9a0527a28d307211c99f105803b21c39e
2 changes: 1 addition & 1 deletion doc/api/tty.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ always return 1.

To enforce a specific color support it's possible to set either one of the
following environment settings.
This rule does not apply to Windows OS, CI environments and some other rare
This rule does not apply to Windows OS, CI environments, and some other rare
cases.

* 2 colors: `NODE_DISABLE_COLORS = 1`
Copy link
Member

@targos targos Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on Windows

Copy link
Member Author

@BridgeAR BridgeAR Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I updated the comment again to reflect that. PTAL.

Expand Down