doc: napi_get_value_bigint_words argument order#26300
Closed
no2chem wants to merge 1 commit intonodejs:masterfrom
no2chem:patch-2
Closed
doc: napi_get_value_bigint_words argument order#26300no2chem wants to merge 1 commit intonodejs:masterfrom no2chem:patch-2
no2chem wants to merge 1 commit intonodejs:masterfrom
no2chem:patch-2
Conversation
nodejs-github-bot
added
doc
lpinca
approved these changes
Feb 25, 2019
mhdawson
approved these changes
Feb 26, 2019
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM, thanks for helping to improve the docs:)
jasnell
approved these changes
Feb 27, 2019
Member
|
LIE CI run: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2719/ since its doc change only. |
Member
|
|
mhdawson
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #26300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
PR-URL: #26300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for
napi_get_value_bigint_wordsappears to have the arguments for word_count and sign_bit flipped. This PR changes the order in the documentation to match the correct order.Checklist