src: apply clang-tidy rule modernize-make-unique#26493
src: apply clang-tidy rule modernize-make-unique#26493gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
dcbea48 to
b4a8d0f
Compare
b4a8d0f to
aa2e90c
Compare
407a683 to
95e1df2
Compare
|
@gengjiawen Would you be able to rebase this and fix the conflict reported? Thanks |
|
@danbev I can fix this evening :) |
95e1df2 to
c04401d
Compare
c04401d to
8eefed0
Compare
|
@danbev I forced push because travis-ci found a lint issue ? Do you need to re-trigger this again ? Sorry for this inconvenience. |
|
Landed in 575e086 🎉 |
PR-URL: nodejs#26493 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
This does not land cleanly on v11. It seems to rely on other commits (e.g. #26306) that should be backported first. Please open a manual backport for it or change the labels accordingly. |
|
I am not familiar with backport process, how should I do it ? |
This comment has been minimized.
This comment has been minimized.
|
If a PR requires manual backports, we should first identify what code it relies upon. There are other PRs that should be backported first as the one that I pointed out. Otherwise there are more conflicts and they become worse over time. So this one should likely not be the first to be backported. @joyeecheung recently added a tool to node-core-utils that is able to identify them (see https://asciinema.org/a/221244). A backport itself is just a PR which targets the staging branches of the release line. In this case |
|
I opened a backport PR for this: #26651 |
PR-URL: nodejs#26493 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #26493 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #26493 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Apply clang-tidy rule https://clang.llvm.org/extra/clang-tidy/checks/modernize-make-unique.html
And also in
Item 21: Prefer std::make_unique and std::make_shared to direct use of new.cc @addaleax @refack @bnoordhuis
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes