test: fix ineffective error tests

[shisama]

Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.

fix #26385

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3316

[BridgeAR]

LGTM while I would prefer to use assert.throws(fn, errorFunction) (or assert.rejects() for promises) instead of try / catch in combination with threw or assert.fail(). That way each test is nicely encapsulated.

[shisama]

@BridgeAR Thank you for your review. I fix this PR to use assert.throws or assert.rejects instead of try / catch. Would you please review this again?

[BridgeAR]

Still LGTM. Thanks for following up on the suggestions.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22650/

[danbev]

Landed in fb3f600.

[ChALkeR]

Thanks for doing this! =)