Closed
Conversation
Some final simplifications for the last few paragraphs of GOVERNANCE.md. Split a long sentence into shorter sentences. Use more consistent text. (A nomination passes rather than "is accepted" to match language in the previous section.)
Collaborator
nodejs-github-bot
added
the
meta
danbev
approved these changes
Apr 23, 2019
BethGriggs
approved these changes
Apr 23, 2019
Trott
added
the
author ready
BridgeAR
approved these changes
Apr 24, 2019
Member
Author
|
Landed in 0a121d3 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 26, 2019
Some final simplifications for the last few paragraphs of GOVERNANCE.md. Split a long sentence into shorter sentences. Use more consistent text. (A nomination passes rather than "is accepted" to match language in the previous section.) PR-URL: nodejs#27354 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Apr 27, 2019
Some final simplifications for the last few paragraphs of GOVERNANCE.md. Split a long sentence into shorter sentences. Use more consistent text. (A nomination passes rather than "is accepted" to match language in the previous section.) PR-URL: #27354 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some final simplifications for the last few paragraphs of GOVERNANCE.md.
Split a long sentence into shorter sentences. Use more consistent text.
(A nomination passes rather than "is accepted" to match language in the
previous section.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes