test:add common.mustCall in test-http-abort-client.js#27449
Closed
Y1D7NG wants to merge 1 commit intonodejs:masterfrom
Closed
test:add common.mustCall in test-http-abort-client.js#27449Y1D7NG wants to merge 1 commit intonodejs:masterfrom
Y1D7NG wants to merge 1 commit intonodejs:masterfrom
Conversation
oyyd
added
the
code-and-learn
starkwang
approved these changes
Apr 28, 2019
gireeshpunathil
approved these changes
Apr 28, 2019
yorkie
approved these changes
Apr 28, 2019
ZYSzys
approved these changes
Apr 28, 2019
ZYSzys
added
the
author ready
Collaborator
Contributor
|
Hi, @OneNail . Can you add a space after "test:" like |
from code-and-learn
Y1D7NG
force-pushed
the
refactorTestHttpAbortClient
branch
from
b67bf3a to
7e2460e
Compare
Collaborator
cjihrig
approved these changes
Apr 28, 2019
Trott
approved these changes
Apr 29, 2019
Collaborator
Collaborator
Contributor
|
Landed in 578b31e, thanks! You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute. |
oyyd
pushed a commit
that referenced
this pull request
Apr 30, 2019
PR-URL: #27449 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
PR-URL: #27449 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor test-http-abort-client to use common.mustCall (from: code-and-learn)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes