test: add mustCallAtLeast to test-fs-read-stream-resume.js#27456
Closed
hdepro wants to merge 1 commit intonodejs:masterfrom
Closed
test: add mustCallAtLeast to test-fs-read-stream-resume.js#27456hdepro wants to merge 1 commit intonodejs:masterfrom
hdepro wants to merge 1 commit intonodejs:masterfrom
Conversation
add mustCallAtLeast to test-fs-read-stream-resume.js
joyeecheung
added
the
code-and-learn
joyeecheung
approved these changes
Apr 28, 2019
Collaborator
oyyd
approved these changes
Apr 28, 2019
cjihrig
approved these changes
Apr 28, 2019
ZYSzys
approved these changes
Apr 28, 2019
Collaborator
ZYSzys
added
the
author ready
Collaborator
Collaborator
Trott
approved these changes
Apr 29, 2019
Contributor
|
Landed in cb41430, thanks! You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute. |
oyyd
pushed a commit
that referenced
this pull request
Apr 30, 2019
add mustCallAtLeast to test-fs-read-stream-resume.js PR-URL: #27456 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
add mustCallAtLeast to test-fs-read-stream-resume.js PR-URL: #27456 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add mustCallAtLeast to test-fs-read-stream-resume.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes