test: converting NghttpError to string in HTTP2 module#27506
Closed
rpgeeganage wants to merge 1 commit intonodejs:masterfrom
Closed
test: converting NghttpError to string in HTTP2 module#27506rpgeeganage wants to merge 1 commit intonodejs:masterfrom
rpgeeganage wants to merge 1 commit intonodejs:masterfrom
Conversation
ZYSzys
approved these changes
May 1, 2019
ZYSzys
reviewed
May 1, 2019
Contributor
Author
|
@BridgeAR , do you think this test case is valid? |
BridgeAR
approved these changes
May 2, 2019
Trott
approved these changes
May 2, 2019
Collaborator
Collaborator
ZYSzys
added
the
author ready
Member
|
Landed in eda4d3c 🎉. |
ZYSzys
pushed a commit
that referenced
this pull request
May 4, 2019
PR-URL: #27506 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 5, 2019
PR-URL: #27506 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This was referenced May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unit test is for converting
NghttpErrorinstance to string usingtoString()function inNghttpErrorclassChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes