test: unmark test-gc-http-client-onerror flaky#28429
Closed
Trott wants to merge 0 commit intonodejs:masterfrom
Closed
test: unmark test-gc-http-client-onerror flaky#28429Trott wants to merge 0 commit intonodejs:masterfrom
Trott wants to merge 0 commit intonodejs:masterfrom
Conversation
Collaborator
addaleax
approved these changes
Jun 25, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
SGTM
Should we run a stress test?
addaleax
added
flaky-test
Member
Author
I didn't because previous attempts to replicate on CI with a stress test came up empty, but I'm happy to try it again if we think there's value in doing so. |
Trott
added
the
author ready
Member
|
No, if you say previous runs didn’t succeed that’s good enough for me :) |
cjihrig
approved these changes
Jun 26, 2019
Collaborator
sam-github
approved these changes
Jun 26, 2019
Collaborator
trivikr
approved these changes
Jun 26, 2019
lpinca
approved these changes
Jun 26, 2019
BridgeAR
approved these changes
Jul 4, 2019
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 4, 2019
The test has not failed on FreeBSD in the last 100 runs and appears to perhaps not be an issue anymore. Closes: nodejs#23089 test-gc-http-client-onerror: PASS,FLAKY PR-URL: nodejs#28429 Fixes: nodejs#23089 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
Author
|
Landed in 727b820 |
Trott
force-pushed
the
unmark-freebsd-flaky
branch
from
e8660b7 to
727b820
Compare
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
The test has not failed on FreeBSD in the last 100 runs and appears to perhaps not be an issue anymore. Closes: #23089 test-gc-http-client-onerror: PASS,FLAKY PR-URL: #28429 Fixes: #23089 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test has not failed on FreeBSD in the last 100 runs and appears to
perhaps not be an issue anymore.
Closes: #23089
test-gc-http-client-onerror: PASS,FLAKY
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes