build: remove --code-cache-path help option#28446
Closed
danbev wants to merge 3 commits intonodejs:masterfrom
Closed
build: remove --code-cache-path help option#28446danbev wants to merge 3 commits intonodejs:masterfrom
danbev wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
Contributor
Author
richardlau
approved these changes
Jun 27, 2019
joyeecheung
approved these changes
Jun 27, 2019
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM, tough TBH I think we should just remove this option as it's obsolete
trivikr
approved these changes
Jun 27, 2019
lpinca
approved these changes
Jun 27, 2019
Contributor
Author
That would be even better. Can I go ahead and remove it? Thanks |
Trott
approved these changes
Jun 28, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM as-is or with the option removed per @joyeecheung's comment and @danbev's response.
This commit removes the now obsolete option.
This commit renames node_code_cache_path and removes the path from as it does not really describe the configuration property as a path anymore. Instead it indicates whether the code cache is used or not.
danbev
force-pushed
the
build_configure_code_cache_path_help
branch
from
f3aac03 to
5dfb434
Compare
danbev
changed the title
Collaborator
Contributor
Author
|
Landed in 39a9358. |
danbev
added a commit
that referenced
this pull request
Jul 4, 2019
This commit removes the now obsolete option. PR-URL: #28446 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
This commit removes the now obsolete option. PR-URL: #28446 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the now obsolete option.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes