build: avoid building V8 snapshot if --without-snapshot

[targos]

/cc @bnoordhuis @refack @ryzokuken

[devsnek]

cc @joyeecheung

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24146/

[joyeecheung]

nit for the commit message: “avoid building the default v8 snapshot...” for clarity (or maybe not, but when I saw the title I thought this was to make —without-snapshot imply —without-node-snapshot)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24156/

[refack]

Refs: #27838 (comment)
/CC @hashseed is it worth it to fight for "no snapshot"?

[refack]

Can we de-dup this a little bit?

    ['v8_use_snapshot==1', {
      'v8_lib_name': 'snapshot',
    }, {
      'v8_lib_name': 'nosnapshot',
    }],
    ['GENERATOR == "ninja"', {
      'obj_dir': '<(PRODUCT_DIR)/obj',
      'v8_base': '<(PRODUCT_DIR)/obj/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
    }, {
      'obj_dir%': '<(PRODUCT_DIR)/obj.target',
      'v8_base': '<(PRODUCT_DIR)/obj.target/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
    }],
    ['OS == "win"', {
      'obj_dir': '<(PRODUCT_DIR)/obj',
      'v8_base': '<(PRODUCT_DIR)/lib/libv8_<(v8_lib_name).a',
    }],
    ['OS == "mac"', {
      'obj_dir%': '<(PRODUCT_DIR)/obj.target',
      'v8_base': '<(PRODUCT_DIR)/libv8_<(v8_lib_name).a',
    }],

[targos]

@refack:

gyp: Undefined variable v8_lib_name in /home/mzasso/git/nodejs/node/node.gyp while trying to load /home/mzasso/git/nodejs/node/node.gyp

[hashseed]

Fwiw we want to remove no snapshot builds from V8 by the end of this year. We are working on the blockers of that right now. Reason is that it now takes unreasonable amount of time to run without snapshot, and also doesn't match what we ship.

[targos]

That's good to know. We should probably remove or at least deprecate nosnapshot support in v13 then.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24239/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24310/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24314/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24319/

[targos]

The same tests failed three times in a row. It seems unlikely to be a flake, but they didn't fail in previous runs. I don't know what to do now...

[addaleax]

• 'CERT_HAS_EXPIRED'

• 'DEPTH_ZERO_SELF_SIGNED_CERT'

Sounds like maybe an issue with the time config for the CI machine? /cc @nodejs/build-infra 

[targos]

I rebased on master and reworded the commit message. Maybe CI will pass now.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/24399/

[targos]

Landed in a8ed416