Conversation
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. Would be nice to have a doc lint rule.
Agreed. It's a bit annoying that the doc rules exist outside of core. |
Yeah, I'd be for reversing the flow to make this easier on us. In other words, instead of adding a rule to the That might also involve undoing some or all of the rollup stuff for lint-md too, though. |
cjihrig
added
the
author ready
Update the API docs to always spell as Unix. PR-URL: nodejs#28576 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Update the API docs to always spell as Unix. PR-URL: #28576 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
9 participants
Update the API docs to always spell as Unix for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes