http2: override authority with options#28584
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Make `options.host` and `options.port` take precedence over `authority.host` and `authority.port` respectively. Fixes: nodejs#28182
addaleax
approved these changes
Jul 7, 2019
Trott
approved these changes
Jul 8, 2019
Member
|
I imagine this doesn't require any documentation adjustments/improvements, but just in case, mentioning it here anyway. |
fhinkel
approved these changes
Jul 8, 2019
trivikr
approved these changes
Jul 9, 2019
Collaborator
Member
Author
|
Landed in e800f9d. |
lpinca
added a commit
that referenced
this pull request
Jul 10, 2019
Make `options.host` and `options.port` take precedence over `authority.host` and `authority.port` respectively. PR-URL: #28584 Fixes: #28182 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
Make `options.host` and `options.port` take precedence over `authority.host` and `authority.port` respectively. PR-URL: #28584 Fixes: #28182 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 23, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
options.hostandoptions.porttake precedence overauthority.hostandauthority.portrespectively.Fixes: #28182
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes