Skip to content

deps: backport 6d32be2 from v8's upstream#2916

Closed
targos wants to merge 1 commit intonodejs:masterfrom
targos:v8-bind
Closed

deps: backport 6d32be2 from v8's upstream#2916
targos wants to merge 1 commit intonodejs:masterfrom
targos:v8-bind

Conversation

@targos
Copy link
Copy Markdown
Member

@targos targos commented Sep 16, 2015

Original commit message:

[es6] Bound function name

Instead of updating the SharedFuntionInfo set the name property on
the function directly.

BUG=v8:4278
LOG=N
R=verwaest@chromium.org, littledan@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1227523003

Cr-Commit-Position: refs/heads/master@{#29558}

Fixes: #2754

/cc @rvagg @nodejs/v8

@targos
deps: backport 6d32be2 from v8's upstream
0823ed2 
Original commit message:

    [es6] Bound function name

    Instead of updating the SharedFuntionInfo set the name property on
    the function directly.

    BUG=v8:4278
    LOG=N
    R=verwaest@chromium.org, littledan@chromium.org
    CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

    Review URL: https://codereview.chromium.org/1227523003

    Cr-Commit-Position: refs/heads/master@{nodejs#29558}

Fixes: nodejs#2754
@targos targos mentioned this pull request Sep 16, 2015
Closed
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Sep 16, 2015
@wraithan
Copy link
Copy Markdown

wraithan commented Sep 16, 2015

This fixes that example @lykkin gave in #2754:

Input:

function fn() {}

var b = fn.bind(null)
process._rawDebug('_rawDebug:',  b.name)
console.log('console.log:', b.name)

fn.bind(null)
process._rawDebug('_rawDebug:', b.name)
console.log('console.log:', b.name)

Output:

_rawDebug: bound fn
console.log: bound fn
_rawDebug: bound fn
console.log: bound fn

@indutny
Copy link
Copy Markdown
Member

indutny commented Sep 16, 2015

LGTM

@bnoordhuis
Copy link
Copy Markdown
Member

bnoordhuis commented Sep 16, 2015

LGTM. Anyone know why the two .toString() checks were removed rather than updated?

@trevnorris
Copy link
Copy Markdown
Contributor

trevnorris commented Sep 16, 2015

LGTM

@targos
Copy link
Copy Markdown
Member Author

targos commented Sep 16, 2015

CI: https://ci.nodejs.org/job/node-test-commit/604/

@Fishrock123
Copy link
Copy Markdown
Contributor

Fishrock123 commented Sep 16, 2015

New run: https://ci.nodejs.org/job/node-test-pull-request/329/

@Fishrock123
Copy link
Copy Markdown
Contributor

Fishrock123 commented Sep 16, 2015

CI seems fine. cc @targos / @indutny

@indutny
Copy link
Copy Markdown
Member

indutny commented Sep 17, 2015

Let's land this!

targos added a commit that referenced this pull request Sep 17, 2015
@targos @indutny
deps: backport 6d32be2 from v8's upstream
d7da617 
Original commit message:

    [es6] Bound function name

    Instead of updating the SharedFuntionInfo set the name property on
    the function directly.

    BUG=v8:4278
    LOG=N
    R=verwaest@chromium.org, littledan@chromium.org
    CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

    Review URL: https://codereview.chromium.org/1227523003

    Cr-Commit-Position: refs/heads/master@{#29558}

Fixes: #2754
PR-URL: #2916
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@indutny
Copy link
Copy Markdown
Member

indutny commented Sep 17, 2015

Landed in d7da617, thank you!

@indutny indutny closed this Sep 17, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 17, 2015
@targos @Fishrock123
deps: backport 6d32be2 from v8's upstream
96670eb 
Original commit message:

    [es6] Bound function name

    Instead of updating the SharedFuntionInfo set the name property on
    the function directly.

    BUG=v8:4278
    LOG=N
    R=verwaest@chromium.org, littledan@chromium.org
    CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

    Review URL: https://codereview.chromium.org/1227523003

    Cr-Commit-Position: refs/heads/master@{nodejs#29558}

Fixes: nodejs#2754
PR-URL: nodejs#2916
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos deleted the v8-bind branch September 17, 2015 04:42
@rvagg rvagg mentioned this pull request Sep 22, 2015
Merged
@MylesBorins
Copy link
Copy Markdown
Contributor

MylesBorins commented Nov 16, 2015

landed in lts-v4.x-staging as 96670eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos @wraithan @indutny @bnoordhuis @trevnorris @Fishrock123 @MylesBorins @jasnell