module: avoid passing unnecessary loop reference#29275
Closed
saghul wants to merge 1 commit intonodejs:masterfrom
Closed
module: avoid passing unnecessary loop reference#29275saghul wants to merge 1 commit intonodejs:masterfrom
saghul wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
It's a sync request, which doesn't require the loop parameter to be set.
cjihrig
approved these changes
Aug 22, 2019
richardlau
approved these changes
Aug 22, 2019
addaleax
approved these changes
Aug 22, 2019
jasnell
approved these changes
Aug 22, 2019
Collaborator
richardlau
added
the
author ready
saghul
added a commit
that referenced
this pull request
Aug 23, 2019
It's a sync request, which doesn't require the loop parameter to be set. PR-URL: #29275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in 2fc8768 thanks for the quick reviews! |
4 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
It's a sync request, which doesn't require the loop parameter to be set. PR-URL: #29275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a sync request, which doesn't require the loop parameter to be set.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes