errors: provide defaults for unmapped uv errors#29288
Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
Closed
errors: provide defaults for unmapped uv errors#29288cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
errors
lpinca
approved these changes
Aug 24, 2019
bnoordhuis
approved these changes
Aug 25, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM but note there's another lazyErrmapGet() in lib/internal/util.js because of course there is.
That one handles missing entries by returning Unknown system error ${err}. That's arguably a little nicer for debugging.
Collaborator
Contributor
Author
That one is gone, as of #29285.
I've updated the PR so that |
libuv does not map 100% of errors. When an unmapped error is encountered, the Map returns undefined, which is then unsuccessfully destructured, causing an exception. This commit adds a default value in the event of an unmapped error.
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/25268/ EDIT: CI was yellow. |
cjihrig
added
the
author ready
Member
|
Landed in c246f81 |
Trott
pushed a commit
that referenced
this pull request
Aug 27, 2019
libuv does not map 100% of errors. When an unmapped error is encountered, the Map returns undefined, which is then unsuccessfully destructured, causing an exception. This commit adds a default value in the event of an unmapped error. PR-URL: #29288 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
libuv does not map 100% of errors. When an unmapped error is encountered, the Map returns undefined, which is then unsuccessfully destructured, causing an exception. This commit adds a default value in the event of an unmapped error. PR-URL: #29288 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
libuv does not map 100% of errors. When an unmapped error is encountered, the Map returns undefined, which is then unsuccessfully destructured, causing an exception. This commit adds a default value in the event of an unmapped error. PR-URL: #29288 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libuv does not map 100% of errors. When an unmapped error is encountered, the
Mapreturnsundefined, which is then unsuccessfully destructured, causing an exception. This commit adds a default value in the event of an unmapped error.A test will be added once #29285 lands.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes