Closed
Conversation
nodejs-github-bot
added
the
v8 engine
Collaborator
Collaborator
cjihrig
approved these changes
Aug 27, 2019
Collaborator
addaleax
approved these changes
Aug 27, 2019
gengjiawen
approved these changes
Aug 28, 2019
Collaborator
bnoordhuis
approved these changes
Aug 28, 2019
Member
|
Are V8 updates treated differently than other PRs? Or is this ready to land? |
Member
Author
|
@Trott the only difference is that we must run the test-commit-v8-linux job, which I did (and it was green). |
Contributor
|
Landed in 858db73. |
danbev
pushed a commit
that referenced
this pull request
Aug 30, 2019
PR-URL: #29336 Refs: v8/v8@7.7.299.4...7.7.299.8 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
Author
|
Backport blocked on #29241 |
targos
added a commit
to targos/node
that referenced
this pull request
Sep 17, 2019
PR-URL: nodejs#29336 Refs: v8/v8@7.7.299.4...7.7.299.8 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
added a commit
that referenced
this pull request
Sep 19, 2019
PR-URL: #29336 Refs: v8/v8@7.7.299.4...7.7.299.8 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This was referenced Sep 25, 2019
This was referenced Sep 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@7.7.299.4...7.7.299.8
/cc @nodejs/v8-update