Skip to content

test: remove Windows skipping of http keepalive request GC test #29354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: remove Windows skipping of http keepalive request GC test #29354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove Windows skipping of http keepalive request GC test 
Remove code to skip Windows in test-http-server-keepalive-req-gc. The
test now works reliably on Windows (I think).
  • Loading branch information
@Trott
Trott committed Aug 28, 2019
commit af59dde7fef28e1f2f411b5977cb86b387d56f25
5 changes: 0 additions & 5 deletions test/parallel/test-http-server-keepalive-req-gc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const onGC = require('../common/ongc');
const { createServer } = require('http');
const { connect } = require('net');

if (common.isWindows) {
// TODO(addaleax): Investigate why and remove the skip.
common.skip('This test is flaky on Windows.');
}

// Make sure that for HTTP keepalive requests, the req object can be
// garbage collected once the request is finished.
// Refs: https://github.com/nodejs/node/issues/9668
Expand Down