doc: change the 'txt' to 'console' for a command#29389
Closed
SEWeiTung wants to merge 1 commit intonodejs:masterfrom
SEWeiTung:ChangeDocFormation
Closed
doc: change the 'txt' to 'console' for a command#29389SEWeiTung wants to merge 1 commit intonodejs:masterfrom SEWeiTung:ChangeDocFormation
SEWeiTung wants to merge 1 commit intonodejs:masterfrom
SEWeiTung:ChangeDocFormation
Conversation
This is the document formation, because `node` is a command to be executed, we should reguard it as a command prompt instead of a command txt type.
patilharshal16
approved these changes
Sep 2, 2019
Trott
approved these changes
Sep 3, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
I imagine this makes no difference in terms of rendering, but for semantics for people viewing raw markdown (which we should definitely accommodate as much as possible IMO), this is probably an improvement, so 👍 from me.
Member
trivikr
approved these changes
Sep 3, 2019
Trott
added
the
author ready
Member
|
Landed in 3c84556 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 3, 2019
This is the document formation, because `node` is a command to be executed, we should reguard it as a command prompt instead of a command txt type. PR-URL: nodejs#29389 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
This is the document formation, because `node` is a command to be executed, we should reguard it as a command prompt instead of a command txt type. PR-URL: #29389 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the document formation, because
nodeis a command to beexecuted, we should reguard it as a command prompt instead of a command
txt type. Notice that if this is a pure txt file of command, it should be something
like what we see in 'doc/api/tracing.md (L39-41)'.
make -j4 test(UNIX), orvcbuild test(Windows) passes