Skip to content

Revert "build: add full Python 3 tests to Travis CI"#29406

Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis:revert29360
Closed

Revert "build: add full Python 3 tests to Travis CI"#29406
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis:revert29360

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Sep 2, 2019

Reverted for breaking the Travis CI builds with the following error:

$ cp ${PYTHON2_CACHE}/node out/Release/node

cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
or directory

The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

Please 👍 this to fast-track it. cc @cclauss

@bnoordhuis
Revert "build: add full Python 3 tests to Travis CI"
e46b9e9 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: nodejs#29360
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 2, 2019
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 2, 2019
@richardlau
Copy link
Member

richardlau commented Sep 2, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3875/

(Kind of superfluous as this is a Travis change.)

cclauss
cclauss approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert... Sorry.

@Trott
Copy link
Member

Trott commented Sep 3, 2019

Landed in cd2a3f8

@Trott Trott closed this Sep 3, 2019
Trott pushed a commit that referenced this pull request Sep 3, 2019
@bnoordhuis @Trott
Revert "build: add full Python 3 tests to Travis CI"
cd2a3f8 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

PR-URL: #29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@bnoordhuis bnoordhuis deleted the revert29360 branch September 3, 2019 15:30
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Sep 3, 2019
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@bnoordhuis @BridgeAR
Revert "build: add full Python 3 tests to Travis CI"
e6aca32 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

PR-URL: #29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@bnoordhuis @BridgeAR
Revert "build: add full Python 3 tests to Travis CI"
449f1fd 
Reverted for breaking the Travis CI builds with the following error:

    $ cp ${PYTHON2_CACHE}/node out/Release/node

    cp: cannot stat '/home/travis/.ccache/py2.7.15/node': No such file
    or directory

    The command "cp ${PYTHON2_CACHE}/node out/Release/node" failed and
    exited with 1 during .

This reverts commit c602b0a.

Refs: #29360

PR-URL: #29406
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@cclauss cclauss cclauss approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

+2 more reviewers

@antsmartian antsmartian antsmartian approved these changes

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. python PRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@bnoordhuis @richardlau @Trott @antsmartian @cjihrig @cclauss @gengjiawen @devnexen @nodejs-github-bot